changing drupal toolbar help link to something more useful

Sun, Nov 26, 2023

This should have worked. It ran, it made the change in the alter hook, but had no effect on the toolbar menu:

/**
 * Implements hook_menu_links_discovered_alter().
 *
 * Replace admin help overview link path with our own.
 *
 * This is easier than simply disabling the old link and adding a new link
 * because Claro/Gin uses the machine ID class to provide the proper icon AND
 * something (also in Claro/Gin?) is overriding menu link weights to place
 * Configuration and Help last (so our Help would be before Configuration).
 */
function mass_menu_links_discovered_alter($links) {
  foreach ($links as $name => $link) {
    if (strstr($name, 'help') !== FALSE) {
      $alterable = $link;
    }
  }
  $links['help.main']['route_name'] = 'entity.view.collection'; // 'help.page'
}

Oh hell i forgot to set it to reference didn’t i?

OK that would have worked but i ended up doing it this way due to that silly oversight:

/**
 * Implements hook_preprocess_menu().
 */
function mass_preprocess_menu(&$variables) {
  if (isset($variables['theme_hook_original']) && $variables['theme_hook_original'] == 'menu__toolbar__admin') {
    // Point help menu item to MASS help page.
    if (isset($variables['items']['help.main'])) {
      $options = $variables['items']['help.main']['url']->getOptions();
      $variables['items']['help.main']['url'] = \Drupal\Core\Url::fromRoute('help.page', ['name' => 'mass'])->setOptions($options);
    }
  }
}